Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(tidb): prioritize the PRs with Priority/P* labels in merging queue #971

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Oct 11, 2023

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: ref pingcap/tidb#41241

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

@ti-chi-bot ti-chi-bot bot requested a review from purelind October 11, 2023 06:27
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2023
@wuhuizuo
Copy link
Contributor Author

For pingcap/tidb#47123

@wuhuizuo
Copy link
Contributor Author

/hold

Should cancel the hold when pingcap/tidb#47123 is approved and passed on CI jobs.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
Copy link
Contributor

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-11 07:21:57.882807653 +0000 UTC m=+1209715.469917798: ☑️ agreed by purelind.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 11, 2023
@wuhuizuo
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 68a79c3 into main Oct 13, 2023
@ti-chi-bot ti-chi-bot bot deleted the feature/support-tide-merge-prioritize branch October 13, 2023 13:06
@wuhuizuo
Copy link
Contributor Author

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants