Add support for text columns for secure matchers #1479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, using the
text
datatype for thehas_secure_token
functionality is supported in Rails, but when used alongside shoulda-matchers it fails as the datatype must bestring
.On codebases that use postgresql, there's no difference between using
text
orstring
and in most cases it makes sense to usetext
.Proposed solution
Add support for
text
datatypes when using thehave_secure_token
matcher.