perf-test: Replace fileType with fileSize #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fileType info is useless for testers
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hermet
reviewed
Jul 24, 2024
| @@ -222,11 +222,15 @@ export default function Home() { | |||
|
|
|||
| for (let i = 0; i < _count; i++) { | |||
| const _anim = animations[Math.floor(Math.random() * animations.length)]; | |||
| const lottieURL = `${urlPrefix}${_anim}`; | |||
|
|
|||
| const response = await fetch(lottieURL); | |||
There was a problem hiding this comment.
this fetching will not affect the loading time? if you think it's ignoreable, it's good to go.
There was a problem hiding this comment.
It affects the loading time and light house score, will fix it soon. Thanks!
There was a problem hiding this comment.
Size is not quite necessary, we can just remove the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileType info is useless for testers