Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeJS support policy and CI improvements #130

Merged
merged 6 commits into from
Nov 20, 2024
Merged

NodeJS support policy and CI improvements #130

merged 6 commits into from
Nov 20, 2024

Conversation

thomvaill
Copy link
Owner

@thomvaill thomvaill commented Oct 30, 2024 •
edited
Loading

Part of #122:

  • Update to latest Github actions versions
  • Simplify yarn caching thanks to the built-in cache of actions/setup-node v4
  • Rename workflows to more explicit ones
  • Use reusable workflows to avoid code duplication
  • Formalize an explicit Node.js support policy: we support active or maintenance LTS version; versions outside of this range are not guaranteed to work; "current" version is supported in a best effort mode
  • Automatize the detection of a new unsupported Node.js LTS release to create an Github issue

@thomvaill thomvaill added this to the v1.1.0 milestone Oct 30, 2024
@thomvaill thomvaill force-pushed the nodejs-support-policy-and-ci-improvements branch from bc60a59 to 9ce5621 Compare October 30, 2024 12:46
@thomvaill thomvaill force-pushed the nodejs-support-policy-and-ci-improvements branch from 9ce5621 to 76b8010 Compare October 30, 2024 12:51
@thomvaill thomvaill force-pushed the nodejs-support-policy-and-ci-improvements branch 2 times, most recently from 4b45b16 to d50cdff Compare October 30, 2024 14:32
@thomvaill thomvaill force-pushed the nodejs-support-policy-and-ci-improvements branch from d50cdff to 85be475 Compare October 30, 2024 17:19
@thomvaill thomvaill marked this pull request as ready for review October 30, 2024 17:26
@thomvaill thomvaill mentioned this pull request Oct 30, 2024
Open
5 tasks
apankratiev-syberry
apankratiev-syberry approved these changes Nov 4, 2024
View reviewed changes
Copy link

@apankratiev-syberry apankratiev-syberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

Potherca
Potherca approved these changes Nov 4, 2024
View reviewed changes
Copy link

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, some thoughts but no real critique. 👍

.github/supported_nodejs_versions.json Show resolved Hide resolved
.github/workflows/on-merge-to-develop.yml Show resolved Hide resolved
.github/workflows/reusable-wait-for-npm-version-to-be-published.yml Outdated Show resolved Hide resolved
.github/workflows/reusable-wait-for-npm-version-to-be-published.yml Outdated Show resolved Hide resolved
.github/workflows/scheduled-weekly-new-nodejs-lts-check.yml Outdated Show resolved Hide resolved
.github/workflows/scheduled-weekly-new-nodejs-lts-check.yml Outdated Show resolved Hide resolved
@thomvaill thomvaill merged commit 168b82f into develop Nov 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apankratiev-syberry apankratiev-syberry apankratiev-syberry approved these changes

@Potherca Potherca Potherca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thomvaill @Potherca @apankratiev-syberry