Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipc: move all init parsing to components/modules #9535

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ipc: move all init parsing to components/modules #9535

wants to merge 4 commits into from

Commits on Oct 10, 2024

  1. component: add macro to toggle shims by IPC type 

    Add helper to switch out init calls to shim in conversion functions if
needed.

Signed-off-by: Curtis Malainey <[email protected]>
    @cujomalainey
    cujomalainey committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0eb04fe View commit details
    Browse the repository at this point in the history

  2. cmocka: update create to use standard alloc flow 

    gotta test all the standard flows

Signed-off-by: Curtis Malainey <[email protected]>
    @cujomalainey
    cujomalainey committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1905971 View commit details
    Browse the repository at this point in the history

  3. audio: google: constify ops drivers 

    Never gonna give you up
Never gonna let you down
Never gonna run around and modify you

Signed-off-by: Curtis Malainey <[email protected]>
    @cujomalainey
    cujomalainey committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cae1175 View commit details
    Browse the repository at this point in the history

  4. WIP: Example code for downstream type conversion 

    ONLY COMPILE/FUZZ TESTED

Given we cannot trust our enum field in the IPC as communicator may lie
about the component on the other side and the module adapter is
obscuring the nature of many of the components we need to move the type
casting into the components directly. Here is a breakdown of the general
steps to achieve this.

1. report ipc config size for all versions
2. remove type casting in the IPC3 layer
3. on non module adapter components cast the config in a compile time
   selected shim
4. in the module adapter ipc3 layer, remove type casting again
5. in module adapter components realloc init data and cast over in a
   compile time enabled shim

Signed-off-by: Curtis Malainey <[email protected]>
    @cujomalainey
    cujomalainey committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2566518 View commit details
    Browse the repository at this point in the history