chain_dma: Fix chain DMA transfer #9505
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-katsyuba-intel
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
Fixes chain DMA implementation: wrong calculation of bytes consumed from host and written into HDA link. The problem was reproduced on test with variable bitrate stream. Signed-off-by: Serhiy Katsyuba <[email protected]>
serhiy-katsyuba-intel
force-pushed
the
chaindma_vbr_fix
branch
from
1839853
to
6c8d630
Compare
|
codestyle / checkpatch failure is false positive: |
kv2019i
approved these changes
Sep 23, 2024
serhiy-katsyuba-intel
requested review from
abonislawski,
tmleman and
softwarecki
ujfalusi
reviewed
Sep 24, 2024
tmleman
approved these changes
Sep 24, 2024
ujfalusi
approved these changes
Sep 24, 2024
dnikodem
approved these changes
Sep 24, 2024
|
Temporarily converted to Draft as test_06_05_pass_through_chain_hda_codec_loopback[dma_id=0-dma_id=0-sin_48khz_2ch_5s_mp3_48000Hz_16in16bit_2ch] started to randomly fail with this PR from time to time. |
|
@serhiy-katsyuba-intel any update ? |
The fix triggers occasional chain DMA CI test failure. Most probably, the test would be fixed (or removed from CI). Once the test is fixed I'll un-draft the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chain DMA implementation: wrong calculation of bytes consumed from host and written into HDA link. The problem was reproduced on test with variable bitrate stream.