-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Tune: TDFB: Add generate of few needed blobs #9147
base: main
Are you sure you want to change the base?
Tools: Tune: TDFB: Add generate of few needed blobs #9147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a ```sof`-`` prefix for all tools and put the tools in the module directories.
Yep, maybe I should postpone this and do the tools move first. There will be a bit more blobs add later, e.g. a blob for analog mic DRC. |
Release reminder - one week to v2.11-rc1. |
FYI @singalsu , pushing to v2.12. |
This patch adds a few blobs generate for the beamformer. There is no need to update the blobs in tplg2 since the update has been already done with run of an earlier version of this patch. - Support two mic line array with 74 mm spacing with addition to sof_example_line_array.m and sof_example_two_beams.m - Updates beamformer pass-through configuration blob with steer angle to avoid initialize error. - Adds script sof_example_two_beams_default.m to export generic blobs for 2 and 4 mic line arrays. The parameters are such that the array mic spacing is not critical (delay-and-sum type) and narrow user faced stereo beams. The two beams design functions are split to own files for use from two scripts. Signed-off-by: Seppo Ingalsuo <[email protected]>
3cc4402
to
fc21c47
Compare
This change adds generate of multi-microphone beamformer blobs to apply with UCM2 rules for SOF. Signed-off-by: Seppo Ingalsuo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we may want something in the beamformer Readme.md that describes the tool and usage.
Yep, I added it in the 3rd commit. |
71c3698
to
abe580e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent inline docs and README file on top! No blockers.
src/audio/tdfb/tune/README.md
Outdated
@@ -0,0 +1,41 @@ | |||
# Settings blobs generators for TDFB | |||
|
|||
This directory contains the scripts to generate settgings blobs for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: settgings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, fixed now!
This patch adds a README.md file that explains how various blob generate scrips are used. Signed-off-by: Seppo Ingalsuo <[email protected]>
abe580e
to
5f7e422
Compare
See commit texts for descriptions.