ucm: add support for sof-glkda7219max #26
Conversation
aiChaoSONG
changed the title
|
@plbossart Can we close #7 by this PR? |
| CapturePCM "hw:sofglkda7219max,1" | ||
| CaptureChannels "2" | ||
| } | ||
|
|
There was a problem hiding this comment.
no jack detection information?
There was a problem hiding this comment.
@plbossart As I see from amixer contents, there is no headset jack detection info. only three HDMI jack detection info, and they are added.
'Headphone Jack Switch' is not the one we want.
There was a problem hiding this comment.
it's in the machine driver
/*
* Headset buttons map to the google Reference headset.
* These can be configured by userspace.
*/
ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
SND_JACK_HEADSET | SND_JACK_BTN_0 | SND_JACK_BTN_1 |
SND_JACK_BTN_2 | SND_JACK_BTN_3 | SND_JACK_LINEOUT,
&broxton_headset, NULL, 0);
There was a problem hiding this comment.
@plbossart Yes, "Headset Jack" is in the driver, but I am sure it's not in the amixer contents (attached). seems we got an issue here.
I add some info as chrome did:
JackName "sofglkda7219max Headset Jack"
JackControl "Headset Jack"
JackType "gpio"
but jack detection not work at all, there is always a headset playback/ headset capture item in sound settings even without a headset inserted. we have the same situation on helios
I am kind of confused.
glk_amixer.log
| Value { | ||
| PlaybackPCM "hw:sofglkda7219max,1" | ||
| PlaybackChannels "2" | ||
| } |
There was a problem hiding this comment.
@plbossart for HDMI we got JackControl "HDMI/DP,pcm=7 Jack", but for headset, seems no such info in amixer contents, so headphone JackControl, and jack detection related is not present in this ucm.
There was a problem hiding this comment.
well jack detection should be added here for headphones/headset. It's supported in the machine driver so there's no reason to remove it.
aiChaoSONG
force-pushed
the
glk
branch
2 times, most recently
from
df28567
to
6a45d0e
Compare
Signed-off-by: Amery Song <[email protected]>
add support for sof-glkda7219max, this ucm is for GLK chromebook with da7219 codec