-
Notifications
You must be signed in to change notification settings - Fork 44
add dark theme option #11
base: master
Are you sure you want to change the base?
Conversation
98a87e6
to
6d005bc
Compare
script.js
Outdated
function setDarkTheme() { | ||
$('body').addClass('dark'); | ||
$('#dark-button').hide(); | ||
$('#light-button').show(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the buttons visibility can be set in CSS like so:
body.dark #dark-button {
visible: false; /* or alternatively; display:none */
}
I like the addition of themes, I'd recommend instead of storing the property as |
Kept both buttons visible at all times, assuming that with the addition of more themes, there will be a row of theme selection buttons in the bottom left. Maybe a dropdown if it gets too long |
Looks great! 👍 |
border-style: solid; | ||
border-radius: 2px; | ||
font-size: 14px; | ||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend an outline:none
here to prevent the browser from giving the buttons an extra highlight when clicked.
|
No description provided.