-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions to support supervised project #69
base: development
Are you sure you want to change the base?
Conversation
Hi @SabrinaRichter, It looks like this pull-request is has been made against the theislab/ncem You do not need to close this PR, you can change the target branch to Thanks again for your contribution! |
@AnnaChristina the supervised manuscript works on binary cell types for schuerch (https://github.com/theislab/tissue/blob/b53bcd6bbeefb10f2930fc5c55e51d6d4cfefa4c/tissue/data.py#L1641) |
I would define this as an additional column in obs of celldata, and I'll check how we ensure this is then subsequently used. Yes would also go for the set default als many plotting function in ncem require the preprocessed cell names |
see my edit above? |
Yes also just edited! |
Can you check out the latest commit? should not have any effect on your code. currently only one level is saved in obs, but one can select which one in the init method |
Looks good to me. |
PR Checklist
docs
is updatedDescription of changes
Technical details
Additional context