Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions to support supervised project #69

Open
wants to merge 14 commits into
base: development
Choose a base branch
from

Conversation

SabrinaRichter
Copy link
Member

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  • added functionality for self-supervision models to the GraphTools class, should not affect the remaining project

Technical details

Additional context

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Hi @SabrinaRichter,

It looks like this pull-request is has been made against the theislab/ncem master or main branch.
The master/main branch should always contain code from the latest release.
Because of this, PRs to master/main are only allowed if they come from any theislab/ncem release or patch branch.

You do not need to close this PR, you can change the target branch to development by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@SabrinaRichter SabrinaRichter changed the base branch from main to development January 7, 2022 11:30
@SabrinaRichter SabrinaRichter changed the title add self-supervision functionality to GraphTools extensions to support supervised project Jan 7, 2022
@SabrinaRichter SabrinaRichter marked this pull request as draft January 7, 2022 11:33
@SabrinaRichter SabrinaRichter changed the title extensions to support supervised project [WIP] extensions to support supervised project Jan 7, 2022
@SabrinaRichter
Copy link
Member Author

SabrinaRichter commented Jan 14, 2022

@AnnaChristina the supervised manuscript works on binary cell types for schuerch (https://github.com/theislab/tissue/blob/b53bcd6bbeefb10f2930fc5c55e51d6d4cfefa4c/tissue/data.py#L1641)
any idea how you want different coarseness levels being handled? multiple cluster_col_xxx columns and then optionally selecting another cluster_col for node_type one-hot encoding set to 'cluster_col_preprocessed' by default?

@AnnaChristina
Copy link
Member

AnnaChristina commented Jan 14, 2022

I would define this as an additional column in obs of celldata, and I'll check how we ensure this is then subsequently used.

Yes would also go for the set default als many plotting function in ncem require the preprocessed cell names

@SabrinaRichter
Copy link
Member Author

see my edit above?

@AnnaChristina
Copy link
Member

Yes also just edited!

@SabrinaRichter
Copy link
Member Author

Can you check out the latest commit? should not have any effect on your code. currently only one level is saved in obs, but one can select which one in the init method

@AnnaChristina
Copy link
Member

Looks good to me.

@SabrinaRichter SabrinaRichter marked this pull request as ready for review February 7, 2022 14:28
@SabrinaRichter SabrinaRichter changed the title [WIP] extensions to support supervised project extensions to support supervised project Feb 7, 2022
@AnnaChristina AnnaChristina self-requested a review February 7, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants