Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37846 - Support Rails 7.0 #762

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fixes #37846 - Support Rails 7.0 #762

merged 1 commit into from
Oct 23, 2024

Conversation

ofedoren
Copy link
Member

No description provided.

ofedoren
ofedoren commented Oct 22, 2024
View reviewed changes
Copy link
Member Author

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this PR depends on Foreman's one, I don't seem to find to_fs on TimeWithZone in Rails 6.1 :/

ekohl
ekohl requested changes Oct 22, 2024
View reviewed changes
lib/foreman_tasks/cleaner.rb Outdated Show resolved Hide resolved
@adamruzicka adamruzicka merged commit 4f857aa into theforeman:master Oct 23, 2024
23 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren & @ekohl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Rails 7.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofedoren @adamruzicka @ekohl