Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for Jenkins EL9 node #1892

Closed
wants to merge 2 commits into from
Closed

Allow for Jenkins EL9 node #1892

wants to merge 2 commits into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 9, 2023

No description provided.

ekohl
ekohl reviewed Sep 10, 2023
View reviewed changes
puppet/modules/slave/manifests/unittests.pp Outdated Show resolved Hide resolved
puppet/modules/slave/manifests/unittests.pp Outdated Show resolved Hide resolved
puppet/modules/slave/manifests/packaging/rpm.pp Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the node-el9 branch 3 times, most recently from 4a11b5e to 75d9ff1 Compare September 11, 2023 15:14
@ehelms ehelms requested a review from evgeni September 11, 2023 15:39
@ehelms
Copy link
Member Author

ehelms commented Sep 11, 2023

Pulled the git-annex standalone change to #1900 in order to allow EL8 based nodes to be used for all workloads similar to EL7 today.

EL9 has a big caveat with NodeJS that complicates things, and while we can/should merge this I'd prefer to pursue moving to EL8 for nodes rather than splitting their usage and wasting resources.

@evgeni
Copy link
Member

evgeni commented Sep 11, 2023 •
edited
Loading

can you elaborate on the caveat? EL8 is EOL next year, so it would be cool if we would be able to deploy EL9 directly or at least have a description of the issue we need to solve before that.

or is it just the fact that there is only 16+ in the repos?

@ehelms
Copy link
Member Author

ehelms commented Sep 11, 2023

can you elaborate on the caveat? EL8 is EOL next year, so it would be cool if we would be able to deploy EL9 directly or at least have a description of the issue we need to solve before that.

or is it just the fact that there is only 16+ in the repos?

It's a couple items:

  • NodeJS 16 (default) or NodeJS 18 (via module) are the only NodeJS runtimes available
  • NodeJS 16 does not provide the nodejs-devel package, it's in EPEL
    ** The nodejs and nodejs-devel RPMs can be out of sync due to separate release streams as they are at the time of this writing

@evgeni
Copy link
Member

evgeni commented Sep 11, 2023

This sounds like blockers to deploy Foreman on EL9 too?

@ehelms
Copy link
Member Author

ehelms commented Sep 11, 2023 via email

ekohl
ekohl reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took your PR and created #1929 as an alternative which I think is a bit cleaner.

puppet/modules/slave/manifests/unittests.pp
}

# nodejs/npm for JavaScript tests
if $facts['os']['family'] == 'RedHat' {
if $facts['os']['family'] == 'RedHat' and !$is_el9 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nodejs module downloads it from https://nodejs.org/download/release/v12.22.12/ and since daf7beb this works:

Suggested change
if $facts['os']['family'] == 'RedHat' and !$is_el9 {
if $facts['os']['family'] == 'RedHat' {

@ehelms ehelms closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Odilhao Odilhao Odilhao left review comments

@ekohl ekohl ekohl left review comments

@evgeni evgeni Awaiting requested review from evgeni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehelms @evgeni @ekohl @Odilhao