Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize Deploying Foreman on AWS guide #3469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modularize Deploying Foreman on AWS guide #3469

wants to merge 1 commit into from

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

making "deploying foreman on AWS" modular

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

I want to incorporate this guide downstream.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

expected "changes" as reported by GH bot: images which are due to the path. Else, there should not be any diff.

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (Satellite 6.17)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@maximiliankolb maximiliankolb marked this pull request as draft November 25, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

The PR preview for 58b3520 is available at theforeman-foreman-documentation-preview-pr-3469.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@maximiliankolb maximiliankolb marked this pull request as ready for review November 28, 2024 09:21
@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective Needs style review Requires a review from docs style/grammar perspective and removed Not yet reviewed labels Nov 28, 2024
@maximiliankolb
Copy link
Contributor Author

Set "tech review done" because https://theforeman-foreman-documentation-preview-pr-3469.surge.sh/diff.html does not show any actual diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteflova asteflova Awaiting requested review from asteflova

Assignees
No one assigned
Labels
Needs style review Requires a review from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maximiliankolb