vale #3147
vale #3147
Conversation
|
The PR preview for 2ce46e7 is available at theforeman-foreman-documentation-preview-pr-3147.surge.sh The following output files are affected by this PR: |
We have an excessive symlink farm pointint at guides/common, vale rescans that every time when scanning the individual guides, which makes it super slow (35min on my laptop), excluding the links in guides/doc-* makes it quite fast (90sec on my latop) as it now only scans guides/common once. Also exclicitly use the github-pr-annotations reporter, which works w/o elevated GITHUB_TOKEN privileges and thus also from forked repos.
| - uses: errata-ai/vale-action@reviewdog | ||
| with: | ||
| filter_mode: diff_context | ||
| vale_flags: "--no-exit --minAlertLevel=error --glob=!*/doc-*/common/*" |
There was a problem hiding this comment.
*.adoc will prevent the sym links problem
There was a problem hiding this comment.
Doesn't work for me locally.
Running it with --glob='*.adoc' (quoted, so my shell doesn't interpret the *) and it spins for minutes now.
There was a problem hiding this comment.
Sorry, I misread your earlier comment. No, I meant this: --glob=!*/doc-*/common/*.adoc"
There was a problem hiding this comment.
but now I'm not certain. I have not used that flag.
| vale_flags: "--no-exit --minAlertLevel=error --glob=!*/doc-*/common/*" | ||
| # github-pr-annotations doesn't require elevated token privileges | ||
| reporter: github-pr-annotations | ||
| fail_on_error: true |
There was a problem hiding this comment.
It has annotations, but the check doesn't appear to fail. That's confusing to me.
|
#3145 was merged. |
Please cherry-pick my commits into: