Solver for equations over ℚ #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TOTBWF
previously approved these changes
Sep 11, 2024
TOTBWF
previously approved these changes
Sep 12, 2024
Taneb
reviewed
Sep 18, 2024
plt-amy
force-pushed
the
aliao/rat-solver
branch
from
bcd4378
to
a30b226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can re-use the ring solver for expressions over ℚ, even involving inverses. The gist of it is that we can re-express any equation involving inverses to an equation between quotients of polynomials, then invoke the ring solver. Even though this idea seemed pretty dumb (surely there would be a cleverer algorithm over ℚ?), it's what the Rocq
fieldtactic does as well. I also added some more comments explicating why ℚ is defined the way it is.