This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Don't parse dates with more than 4 digits for the year #556
Open
heinrich5991
wants to merge
2
commits into
the-paperless-project:master
Choose a base branch
from
heinrich5991:pr_dates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex was broken before, using `(?!…)` instead of `(?<=…)`.
skius
previously approved these changes
Aug 19, 2019
Why do we need to lookbehind and lookahead? Can't we get away with something like this? r = re.compile(r'(?:\b|[_-])('\
r'(?:[0-9]{1,2}[./-][0-9]{1,2}[./-](?:[0-9]{4}|[0-9]{2}))|'\
r'(?:(?:[0-9]{4}|[0-9]{2})[./-][0-9]{1,2}[./-][0-9]{1,2})|'\
r'(?:[0-9]{1,2}\. +[^\W\d_]{3,9} (?:[0-9]{4}|[0-9]{2}))|'\
r'(?:[^\W\d_]{3,9}(?: [0-9]{1,2},)? [0-9]{4})'\
r')(?:\b|[_-])') In some manual testing, it seems to match everything matched in the unit tests. We can then use 👍 for the additional tests. |
Updated with the suggestion to not use lookahead/lookbehind. |
Removed all the superfluous |
Great, could you also remove the superfluous |
MasterofJOKers
previously approved these changes
Nov 2, 2019
heinrich5991
force-pushed
the
pr_dates
branch
from
November 2, 2019 12:02
1984972
to
a268199
Compare
Removed the superfluous backslashes in the regex. |
MasterofJOKers
approved these changes
Nov 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex was broken before, using
(?!…)
instead of(?<=…)
.