Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove unused rest apis #1529

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Rup-Narayan-Rajbanshi
Copy link
Contributor

Addresses

Changes

  • Remove rest endpoints that has graphql implementatons.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review September 26, 2024 05:57
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@1ad6182). Learn more about missing BASE report.
Report is 343 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1529   +/-   ##
==========================================
  Coverage           ?   79.48%           
==========================================
  Files              ?      463           
  Lines              ?    29828           
  Branches           ?     3359           
==========================================
  Hits               ?    23710           
  Misses             ?     6118           
  Partials           ?        0           
Flag Coverage Δ
79.48% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant