Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] Add volumes for server media/static files #61

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[DEV] Add volumes for server media/static files #61

merged 1 commit into from
Sep 28, 2023

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Sep 28, 2023 •
edited
Loading

  • Addresses assets directory in backend

Changes

  • Use volume to store backend files

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks

@thenav56 thenav56 marked this pull request as ready for review September 28, 2023 06:27
@subinasr subinasr self-assigned this Sep 28, 2023
@subinasr subinasr merged commit 73f30c9 into develop Sep 28, 2023
7 checks passed
@subinasr subinasr deleted the feature/volume-for-server-documents branch September 28, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subinasr subinasr subinasr approved these changes

Assignees

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenav56 @subinasr