Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rate in toggleHowler #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrdziuban
Copy link

Currently updating the rate prop after initial render has no effect. It looks like this is because componentDidUpdate calls toggleHowler and toggleHowler does not call this.rate like it does with this.volume.

This updates toggleHowler to add the appropriate call to this.rate when the new rate prop differs from the previous prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant