Create socket in YowNetworkLayer with socket.create_connection #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following this PR as I have troubles with IPv6-only environment. The current workaround solves it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across a problem with
yowsupin an IPv6 network. Currently,AF_INETsocket is always created during connection to WhatsApp endpoints, and it fails to connect to non-IPv4 addresses. However,socketmodule has a convenience functioncreate_connectionthat creates and connects a socket to a given address. It handles detection of address family and socket type itself, thus creating a suitable socket both in IPv4 and IPv6 environments.