Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh Compatibility #1025

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Bokeh Compatibility #1025

merged 1 commit into from
Mar 27, 2024

Conversation

sdc50
Copy link
Member

@sdc50 sdc50 commented Mar 22, 2024

  • bokehjsdir() has been deprecated in favor of bokehjs_path()

* bokehjsdir() has been deprecated in favor of bokehjs_path()

* Apply suggestions from code review

* Added unit test for bokejs_path() import

---------

Co-authored-by: tbg <[email protected]>
Co-authored-by: sdc50 <[email protected]>
@sdc50
Copy link
Member Author

sdc50 commented Mar 27, 2024

@sdc50, @shawncrawley, Since this is on a release branch it won't get the changes that fixed Black that are on the main branch. I think we should just merge this hotfix as is and not worry about Black-ing release branches.

@swainn
Copy link
Member

swainn commented Mar 27, 2024

@sdc50, @shawncrawley, Since this is on a release branch it won't get the changes that fixed Black that are on the main branch. I think we should just merge this hotfix as is and not worry about Black-ing release branches.

I concur

@swainn swainn merged commit 1d56fa6 into release-4.2 Mar 27, 2024
9 of 10 checks passed
@swainn swainn deleted the hotfix/bokehjsdir branch March 27, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants