Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support waiting from both standard streams #695

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DDtKey
Copy link
Collaborator

@DDtKey DDtKey commented Jul 7, 2024

Might be useful to avoid duplication in some cases

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit 7305971
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/668acd4896539900089b90c3
😎 Deploy Preview https://deploy-preview-695--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DDtKey DDtKey marked this pull request as ready for review July 8, 2024 14:12
@DDtKey DDtKey marked this pull request as draft July 8, 2024 14:13
@ns-sjorgedeaguiar
Copy link
Contributor

@DDtKey on a related note, am I right that it's not possible to wait for the command to complete? I see that we can wait for messages to be present in stderr/stdout, or for a specific exit code, but there doesn't seem to be a away to wait until the command finishes regardless of the outcome. There's the timeout option but it sleeps for the whole duration, not circuit breaking when the command is finished.

In my case I wrote a wrapper to execute a SQL statement, and wanted to print whatever error occurred when there was some. The exit code or expected message depended on what the caller was doing (e.g. inserting, deleting, etc) and the exit code could be anything. My workaround was to keep polling until an exit code was available.

@DDtKey
Copy link
Collaborator Author

DDtKey commented Aug 15, 2024

Hi @ns-sjorgedeaguiar
Yes, that's correct. however I think more appropriate place for the discussion is #702

Where you also can find a workaround. But it's something we can support for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants