updated java 8->17 #5511
Open
updated java 8->17 #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! 👏 |
except floodlight and openflowj apache-storm-1.2.1 -> 2.6.0 kafka_2.12-2.0.0 -> 2.12-3.6.0 zookeeper-3.4.9 - > 3.8.3 kilda-gui build success * removed options.compilerArgs << '-Amapstruct.unmappedTargetPolicy=ERROR' from kilda-parent since we need to specify this compilerArg only in modules we use mapstruct * hibernateUpdate to version 6.4.0 fixes * grpc-speaker fixed, spring 5->6, springboot 2->3
IvanChupin
force-pushed
the
improvement/migration-java-8-17
branch
from
6e90410
to
5dc2250
Compare
except floodlight and openflowj apache-storm-1.2.1 -> 2.6.0 kafka_2.12-2.0.0 -> 2.12-3.6.0 zookeeper-3.4.9 - > 3.8.3 kilda-gui build success * removed options.compilerArgs << '-Amapstruct.unmappedTargetPolicy=ERROR' from kilda-parent since we need to specify this compilerArg only in modules we use mapstruct * hibernateUpdate to version 6.4.0 fixes * grpc-speaker fixed, spring 5->6, springboot 2->3 *northbound fixed, added ch.qos.logback as an excluded deps globally for northbound, due to the conflict deps for slf4j, need better solution. * build.gradle - 'zip64 true' for connecteddevices-storm-topology,floodlightrouter,flowhs,flowmonitoring,history-storm,isllatency,nbworker-storm,network-storm * kilda-persistence-tinkerpop fixed, problems with io.netty deps *server42-control spring 5->6, springboot 2->3 *testing spring 5->6, springboot 2->3
except floodlight and openflowj apache-storm-1.2.1 -> 2.6.0 kafka_2.12-2.0.0 -> 2.12-3.6.0 zookeeper-3.4.9 - > 3.8.3 kilda-gui build success * removed options.compilerArgs << '-Amapstruct.unmappedTargetPolicy=ERROR' from kilda-parent since we need to specify this compilerArg only in modules we use mapstruct * hibernateUpdate to version 6.4.0 fixes * grpc-speaker fixed, spring 5->6, springboot 2->3 *northbound fixed, added ch.qos.logback as an excluded deps globally for northbound, due to the conflict deps for slf4j, need better solution. * build.gradle - 'zip64 true' for connecteddevices-storm-topology,floodlightrouter,flowhs,flowmonitoring,history-storm,isllatency,nbworker-storm,network-storm * kilda-persistence-tinkerpop fixed, problems with io.netty deps *server42-control spring 5->6, springboot 2->3 *testing spring 5->6, springboot 2->3 * testing SoftAssertionsWrapper.java
except floodlight and openflowj apache-storm-1.2.1 -> 2.6.0 kafka_2.12-2.0.0 -> 2.12-3.6.0 zookeeper-3.4.9 - > 3.8.3 kilda-gui build success * removed options.compilerArgs << '-Amapstruct.unmappedTargetPolicy=ERROR' from kilda-parent since we need to specify this compilerArg only in modules we use mapstruct * hibernateUpdate to version 6.4.0 fixes * grpc-speaker fixed, spring 5->6, springboot 2->3 *[northbound,server 42-stats] fixed, added ch.qos.logback as an excluded deps globally for northbound, due to the conflict deps for slf4j, need better solution. * build.gradle - 'zip64 true' for connecteddevices-storm-topology,floodlightrouter,flowhs,flowmonitoring,history-storm,isllatency,nbworker-storm,network-storm, ping-topology, portstate-topology, reroute topology, server42-control-storm-topology, stats-storm-topology, swmanager-storm-topology, * kilda-persistence-tinkerpop fixed, problems with io.netty deps *server42-control spring 5->6, springboot 2->3 *testing spring 5->6, springboot 2->3 * testing SoftAssertionsWrapper.java
dmitrii-beliakov
approved these changes
Dec 18, 2023
removed UseConcMarkSweepGC java opetion since it was removed in java 17 zookeeper dockerfile fix hbase updated 1.2.4->2.5.6
sotrm version fix
…ted classes. Update checkstyle.
…Storm's TupleImpl
…ses due to wrong version of snakeyaml.
… module. Add slf4j.
Work around Config bean creation. Adjust kafka clients version for NB module. Add slf4j.
… bean and uncomment the usage of it in MessageConsumerConfig
|
fyi, remember you have to update also this https://github.com/telstra/open-kilda/blob/266c9c15b69010c640af60dba3ce8381946881f6/.github/workflows/unittest.yml |
…oblems. Minor adjustments for serialization.
* reverted to java 8 * dockerfile logic that remove java 17 deps * all deps kept the same * removed old jUnit transitive deps from com.googlecode.json-simple * Unit tests for statsController fixed * small refactoring for FlowConverter.java,FlowPathConverter.java,IslLinkConverter.java,
…_zk_files Replace LazyCollectionOption with fetch type
…-merge-develop Improvement/migration java 8 17 merge develop
…w types (if possible)
…_zk_files Refactor PropertyMethodHandlerWithConverterSupport.java to not use raw types when possible
…_dst-mac-fix Fix deserializer for AddFlow
…-jackson Align jackson dependencies
…ion-java-8-17_from_master
Signed-off-by: olesir <[email protected]>
…_from_master Improvement/migration java 8 17 from master
Signed-off-by: olesir <[email protected]>
…-watchdog Add correlation ID to ZK WatchDog
Signed-off-by: olesir <[email protected]>
…-watchdog Fix build information in healthcheck
…_java_version_jenkins add file to set the java version in jenkins
Signed-off-by: olesir <[email protected]>
…-logs Align log4j version with one from storm
…_javax_jakarta javax->jakarta
# Conflicts: # README.md # confd/templates/makefile/makefile.tmpl # src-java/floodlight-service/floodlight-api/build.gradle # src-java/flowhs-topology/flowhs-messaging/build.gradle # src-java/northbound-service/northbound/build.gradle # src-java/northbound-service/northbound/src/main/java/org/openkilda/northbound/controller/v1/FlowController.java # src-java/testing/functional-tests/src/main/groovy/org/openkilda/functionaltests/helpers/SwitchHelper.groovy # src-java/testing/functional-tests/src/test/groovy/org/openkilda/functionaltests/spec/flows/FlowCrudSpec.groovy # src-java/testing/functional-tests/src/test/groovy/org/openkilda/functionaltests/spec/flows/MultiRerouteSpec.groovy # src-java/testing/performance-tests/src/test/groovy/org/openkilda/performancetests/spec/endurance/EnduranceV2Spec.groovy
IvanChupin
force-pushed
the
improvement/migration-java-8-17
branch
from
4b652b7
to
03da3cd
Compare
…t ensure the creation of initial zookeeper node. +docker-compose. increase the healthcheck interval for zookeeper service
…_zookeeper_fix Zookeeper script for creating zknodes: additional check added
Since updated spring the following error message: 'Required $itemType parameter $item is not present' has been changed to new message: 'Required request parameter $item for method parameter type $itemType is not present'
…_LinkSpecFix Link spec fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except floodlight and openflowj
apache-storm-1.2.1 -> 2.6.0
kafka_2.12-2.0.0 -> 2.12-3.6.0
zookeeper-3.4.9 - > 3.8.3
kilda-gui build success