Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coinpaprika API source #636

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Add coinpaprika API source #636

merged 2 commits into from
Mar 22, 2023

Conversation

akremstudy
Copy link
Collaborator

@akremstudy akremstudy commented Mar 22, 2023

Summary

Add Coinpaprika API source and include the source on the steth and reth feeds.

Steps Taken to QA Changes

Add Coinpaprika api source test

Checklist

This pull request is:

  • A documentation error, docs update, or typographical error fix
    • No tests or issue needed
  • A code fix
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a bug report issue
    • Please include tests. Fixes without tests will not be accepted unless it's related to the documentation only.
    • Please make sure docs are updated if need be
  • A feature implementation
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a feature enhancement issue
    • Please include tests
    • Please make sure docs updates are both thorough and easy to reproduce by somebody with limited knowledge of the feature that you are submitting

Happy engineering!

Copy link
Collaborator

@oraclown oraclown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akremstudy ! Just 1 tiny change needed I think, then merge away

tests/sources/test_spot_price_sources.py Outdated Show resolved Hide resolved
@akremstudy akremstudy merged commit 75576ad into main Mar 22, 2023
@oraclown oraclown deleted the add-coinpaprika-source branch April 29, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants