refactor: use LegacyDec for reward tracking and selector commission rates #441
Conversation
| commission := k.TruncateUint(commissionDec) | ||
|
|
||
| // selector's commission = reporter's commission rate * reward | ||
| commission := reward.Mul(reporter.CommissionRate) |
There was a problem hiding this comment.
Should this commission decimal be truncated before it gets used for more operations ?
There was a problem hiding this comment.
if you're asking because of consistency, maybe this shouldn't be truncated, delegatorShare = delegatorShare.TruncateDec(),
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/v1.x release/v1.x
# Navigate to the new working tree
cd .worktrees/backport-release/v1.x
# Create a new branch
git switch --create backport-441-to-release/v1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49238bb36802c3c2962562530cf9972cbdab9ac0
# Push it to GitHub
git push --set-upstream origin backport-441-to-release/v1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/v1.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/v1.x release/v1.x
# Navigate to the new working tree
cd .worktrees/backport-release/v1.x
# Create a new branch
git switch --create backport-441-to-release/v1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49238bb36802c3c2962562530cf9972cbdab9ac0
# Push it to GitHub
git push --set-upstream origin backport-441-to-release/v1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/v1.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/v1.x release/v1.x
# Navigate to the new working tree
cd .worktrees/backport-release/v1.x
# Create a new branch
git switch --create backport-441-to-release/v1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49238bb36802c3c2962562530cf9972cbdab9ac0
# Push it to GitHub
git push --set-upstream origin backport-441-to-release/v1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/v1.xThen, create a pull request where the |
No description provided.