added query to return info on voting tally for dispute #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable-tips query in the reporter module to return their tips with a precision of 6 instead of 12 so they don't think they have a boat load of tips
danflo27
reviewed
Oct 30, 2024
| @@ -171,3 +173,51 @@ func (s *KeeperTestSuite) TestOpenDisputesQuery() { | |||
| fmt.Println(resp) | |||
| require.Equal(2, len(resp.OpenDisputes.Ids)) | |||
| } | |||
|
|
|||
| func (s *KeeperTestSuite) TestTallyQuery() { | |||
themandalore
approved these changes
Nov 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
* added query to return info on voting tally for dispute. Changed the available-tips query in the reporter module to return their tips with a precision of 6 instead of 12 so they don't think they have a boat load of tips * fixed test for AvailableTips * fixed lint issues * added team vote to the returned data * added check for executed disputes to return a zero'ed BlockInfo Object (cherry picked from commit 5ff6785)
tkernell
pushed a commit
that referenced
this pull request
Nov 4, 2024
* added query to return info on voting tally for dispute. Changed the available-tips query in the reporter module to return their tips with a precision of 6 instead of 12 so they don't think they have a boat load of tips * fixed test for AvailableTips * fixed lint issues * added team vote to the returned data * added check for executed disputes to return a zero'ed BlockInfo Object (cherry picked from commit 5ff6785) Co-authored-by: CJPotter10 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added query to dispute module to get current voting tally for a dispute broken down by group. Changed reporter "available-tips" query to return their tips in Loya (precision of 6) instead of the normalized stored value (precision of 12)