refactor(components): use margin instead of padding in tab-panel (#370)

this allows "margin collapse", so the vertical spacing does not visually break when _unstyled_ block elements with some by-default margins, like p, ul, etc. are used inside the tab-panel Co-authored-by: Daniel Beck <[email protected]>
telekom · May 28, 2021 · 65caecb · 65caecb
1 parent a618efe
commit 65caecb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/components/src/components/modal/modal.css b/packages/components/src/components/modal/modal.css
@@ -209,6 +209,8 @@
 }
 
 .modal--has-body .modal__body {
+  /* we use `margin` and top padding because we want to allow "margin collapse" */
+  /* @see https://web.dev/learn/css/spacing/#margin-collapse */
   margin-top: var(--spacing-y-body);
   margin-bottom: var(--spacing-y-body);
 }

diff --git a/packages/components/src/components/tab-panel/tab-panel.css b/packages/components/src/components/tab-panel/tab-panel.css
@@ -15,9 +15,11 @@
 }
 
 .tab-panel {
-  padding-top: var(--spacing-top);
+  /* we use `margin` and top padding because we want to allow "margin collapse" */
+  /* @see https://web.dev/learn/css/spacing/#margin-collapse */
+  margin-top: var(--spacing-top);
 }
 
 .tab-panel--small {
-  padding-top: var(--spacing-top-small);
+  margin-top: var(--spacing-top-small);
 }