Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PhoneLib 8.13.37, update test for fix of our issue 338710341 and prepare release #66

Merged
merged 1 commit into from
May 21, 2024
Merged

Use PhoneLib 8.13.37, update test for fix of our issue 338710341 and prepare release #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion REPORTED_ISSUES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,6 @@ When we have further insights, we will report them as issues, re-engage with Goo

BnetzA [described special case for NDC 212 and 621](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1) the first one is correctly recognized by geocoder and the two cities are correctly labeled. But the second case is not recognized and only the city Mannheim is used for labeling and not Ludwigshafen.

We have provided Ludwighafen in our labeling data.
We have provided Ludwighafen in our labeling data.

Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<artifactId>normalizer</artifactId>
<name>Phonenumber Normalizer</name>
<description>Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics.</description>
<version>1.2.2-SNAPSHOT</version>
<version>1.2.2</version>
<packaging>jar</packaging>
<url>https://github.com/telekom/phonenumber-normalizer</url>

Expand Down Expand Up @@ -86,7 +86,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>libphonenumber</artifactId>
<version>8.13.36</version>
<version>8.13.37</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -150,7 +150,7 @@
<dependency>
<groupId>com.googlecode.libphonenumber</groupId>
<artifactId>geocoder</artifactId>
<version>2.230</version>
<version>2.231</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
28 changes: 21 additions & 7 deletions ...telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3307,13 +3307,27 @@ class PhoneNumberOfflineGeocoderTest extends Specification {
"6206" | "Lampertheim" | false
"6207" | "Wald Michelbach" | false
"6209" | "Mörlenbach" | false
"621" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
// note of BnetzA, that starting number is sperating both cities: see https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1
"6215" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341
"6216" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341
"62195" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341
"62196" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341
"62199" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341
// 621 extended 0..4, 7&8 because number with starting 5 is added
"6210" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"6211" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"6212" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"6213" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"6214" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
// note of BnetzA, that starting number is separating both cities: see https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1
"6215" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341
"6216" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341
"6217" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"6218" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62190" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62191" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62192" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62193" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62194" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62195" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341
"62196" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341
"62197" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62198" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen
"62199" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341
"6220" | "Wilhelmsfeld" | false
"6221" | "Heidelberg" | false
"6222" | "Wiesloch" | false
Expand Down
Loading