Use PhoneLib 8.13.38 and prepare release (removed NAC from MX numberp…

…lan - as done 5 years ago) (#68)
telekom · May 30, 2024 · 84c7974 · 84c7974
1 parent 9c391c0
commit 84c7974
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -23,7 +23,7 @@
     <artifactId>normalizer</artifactId>
     <name>Phonenumber Normalizer</name>
     <description>Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics.</description>
-    <version>1.2.3-SNAPSHOT</version>
+    <version>1.2.3</version>
     <packaging>jar</packaging>
     <url>https://github.com/telekom/phonenumber-normalizer</url>
 
@@ -86,7 +86,7 @@
         <dependency>
             <groupId>com.googlecode.libphonenumber</groupId>
             <artifactId>libphonenumber</artifactId>
-            <version>8.13.37</version>
+            <version>8.13.38</version>
         </dependency>
 
         <dependency>
@@ -150,7 +150,7 @@
         <dependency>
             <groupId>com.googlecode.libphonenumber</groupId>
             <artifactId>geocoder</artifactId>
-            <version>2.231</version>
+            <version>2.232</version>
             <scope>test</scope>
         </dependency>
         <dependency>

diff --git a/src/test/groovy/de/telekom/phonenumbernormalizer/numberplans/PhoneLibWrapperTest.groovy b/src/test/groovy/de/telekom/phonenumbernormalizer/numberplans/PhoneLibWrapperTest.groovy
@@ -154,7 +154,7 @@ class PhoneLibWrapperTest extends Specification {
         "+49203555666"  | "RU"       | "8"
         "+49203555666"  | "CZ"       | ""
         "+49203555666"  | "HU"       | "06"
-        "+49203555666"  | "MX"       | "01"
+        // "+49203555666"  | "MX"       | "01" v8.13.38 on 30.05.2024 adapted new MX numberplan from 2019 elemination NAC 01
     }
 
     def "hasRegionNationalPrefix"( number,  regionCode, expectedResult) {
@@ -187,7 +187,7 @@ class PhoneLibWrapperTest extends Specification {
         "+49203555666"  | "RU"       | true
         "+49203555666"  | "CZ"       | false
         "+49203555666"  | "HU"       | true
-        "+49203555666"  | "MX"       | true
+        // "+49203555666"  | "MX"       | true  v8.13.38 on 30.05.2024 adapted new MX numberplan from 2019 elemination NAC 01
     }
 
     def "isSpecialFormat"( number,   expectedResult) {