Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update load_astropy.py - big/little endianness (#167) #183

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Update load_astropy.py - big/little endianness (#167) #183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de0227
Update load_astropy.py - big/little endianness (#167)
telegraphic Mar 31, 2024
3534a9c
Update load_astropy.py -- typo
telegraphic Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions hickle/loaders/load_astropy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from astropy.time import Time
from astropy.units import Quantity
import numpy as np
import sys

# hickle imports
from hickle.helpers import no_compression,load_str_list_attr_ascii,load_str_attr_ascii
Expand Down Expand Up @@ -130,7 +131,8 @@ def create_astropy_time(py_obj, h_group, name, **kwargs):
# Need to catch string times, e.g. 1999-01-01T00:00:00.123
# Must be encoded into bytes.
if 'str' in py_obj.value.dtype.name:
bytes_dtype_str = py_obj.value.dtype.str.replace('<U', '|S')
# 2024.03.31 - Convert both big and little endians to |S dtype
bytes_dtype_str = py_obj.value.dtype.str.replace('<U', '|S').replace('>U', '|S')
d = h_group.create_dataset(
name,
data = np.array(py_obj.value.astype(bytes_dtype_str)),
Expand Down Expand Up @@ -260,7 +262,9 @@ def load_astropy_time_dataset(h_node,base_type,py_obj_type):
if dtype:
dtype = np.dtype(dtype)
if 'str' in dtype.name:
bytes_dtype_str = dtype.str.replace('|S', '<U')
# 2024.03.31 - take system endian-ness into account
ustr = '<U' if sys.byteorder == 'little' else '>U'
bytes_dtype_str = dtype.str.replace('|S', ustr)
time_data = np.array(h_node[()]).astype(bytes_dtype_str)
return py_obj_type(time_data, format=fmt, scale=scale)
return py_obj_type(np.array(h_node[()],dtype=dtype), format=fmt, scale=scale)
Expand Down
Loading