Build: Speed up third party libraries cloning #28567
Open
+66
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
If this is to be added it should be non-default and somehow configurable, because I really enjoy full repository histories in the dependencies. |
ilya-fedin
reviewed
Oct 26, 2024
ilya-fedin
reviewed
Oct 26, 2024
|
Maybe squash 1st, 2nd and 4th commits into one? |
difhel
force-pushed
the
build/speed-up-libraries-cloning
branch
from
a37edfe
to
914dc0e
Compare
ilya-fedin
reviewed
Oct 26, 2024
Co-authored-by: ilya-fedin <[email protected]>
difhel
force-pushed
the
build/speed-up-libraries-cloning
branch
from
eddca0c
to
2154526
Compare
john-preston
requested changes
Oct 31, 2024
| if no_deps_git_history: | ||
| print("Notice: Some dependency repositories will be downloaded without full history (via git clone --depth 1) to reduce time and disk space.") | ||
|
|
||
| def git(command, args): |
There was a problem hiding this comment.
This does what I asked, but not the way other things are done here. It looks to me that more consistent with how the script already works would be another approach:
- if 'no-deps-git-history' is passed as an option you add something like 'DEPTH' -> '--depth 1' to the 'environment' map, otherwise set it to an empty string
- in all places necessary just add $DEPTH in the git command so that the '--depth 1' is added if necessary..
If this way it works as expected, then I'd like that approach to be implemented. If somehow I missed something and this doesn't work then we'll proceed with the one you proposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to build Telegram Desktop from source code, I realized it was running pretty darn slow.
When I decided to look into it, I suddenly found out that the preparation script clones the entire git repository index of each third party library used, not just the last commit we need to build. So I looked at which stages
tdesktopuses just a branch (without explicitly checkingout to a specific commit) and added the--depth 1parameter. This greatly reduces build preparation time, as well as disk space and traffic used, since some of the libraries used are very large.