Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest anti-spoof logic for CustomURLs #27669

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

agl-1984
Copy link
Contributor

I want to suggest anti-spoof PR.

To prevent fooling users with links like

  • displayed as one username -> but leads to different one or a website.
  • displayed as one website -> but lead to another website. Currently checking only domain.
  • all hash tags -> should not be a link, I think. Usually they considered as safe options and lead to search results. So I want to warn user if #tag is a link, but not hashtag.

Things to improve: UI and translation is not perfect. Any suggestion are welcomed.

Current changset was tested on a set of 100 links, with various way to specify username, various websites and hashtags trying to cover many different cases, Not mentioned here. Is there a UT infrastructure to automatically regress this feature?

Copy link

@Maniac1488ss Maniac1488ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants