-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace Ctrl+F by F for full screen #26895
base: dev
Are you sure you want to change the base?
Conversation
Why don't you like |
I'm used to use F on youtube and found out about the shortcuts you mentioned while I was searching for shortcuts in the code |
I think changing hotkey that previously worked for years is a bad practice. I think I'll add an ability to customize hotkey to toggle full screen for videos. |
for all plz xd everyone wants to customize hotkeys :) |
But Ctrl+F still works, why is adding new hotkeys bad? |
Hmm, yes, you're right. Alright then, anyway the final decision is up to Preston. |
Now you can customize this shortcut with a new |
I've changed config and now I cannot type f |
😯 |
Okay, there seems to be nothing critical to have an additional hotkey option... |
F as a hotkey is commonly used for toggling full screen and is used in Telegram Web too. Also, there are hotkeys in Telegram Web such as Shift+F, Alt+F, and Ctrl+F that make video go fullscreen.
Previously Ctrl+F hotkey used to make the search bar active, but as far as I can see it got fixed by now.
Closes #25866