Packed resources #17339
Open
Packed resources #17339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I open MRs to submodules as well? |
|
Yes, the submodule PRs should be merged first. |
xvitaly
reviewed
Dec 6, 2021
| install(TARGETS Telegram | ||
| RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}" | ||
| BUNDLE DESTINATION "${CMAKE_INSTALL_BINDIR}" | ||
| RESOURCE DESTINATION "${CMAKE_INSTALL_DATADIR}/TelegramDesktop" |
There was a problem hiding this comment.
Use lowercase directory name here: ${CMAKE_INSTALL_DATADIR}/telegram-desktop.
There was a problem hiding this comment.
Again, the name is not arbitrary here. It should match application name as known to Qt.
https://github.com/telegramdesktop/tdesktop/blob/v3.3.0/Telegram/SourceFiles/core/launcher.cpp#L288
This was referenced Dec 25, 2021
Dynamically load packed resources from a separate file. This reduces amount of main memory required for linking stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically load packed resources from separate file. This reduces amount of main memory required for linking stage.