Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Showing Prompt Immediately After Loading Script #8

Merged
merged 1 commit into from
May 6, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented May 3, 2024

This was a simple fix: after we load a script we were setting a boolean to immediately print a prompt to the user. Simple fix was to set this to false.

NOTE: User can still get a prompt by hitting enter again even while the instrument is busy. Maybe desirable?
@esarver esarver self-assigned this May 3, 2024
@esarver esarver requested a review from a team as a code owner May 3, 2024 19:06
Copy link

github-actions bot commented May 3, 2024

Code Coverage

Package Line Rate Health
kic-discover/src/lib.rs 0%
kic/src/main.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
instrument-repl/src/resources/mod.rs 100%
instrument-repl/src/instrument.rs 86%
kic-discover/src/usbtmc/mod.rs 0%
kic-discover/src/ethernet/mod.rs 0%
instrument-repl/src/state_machine.rs 63%
kic/src/process.rs 0%
instrument-repl/src/tsp_error.rs 0%
instrument-repl/src/error.rs 0%
kic-discover/src/main.rs 0%
instrument-repl/src/repl.rs 0%
kic/src/error.rs 0%
Summary 16% (295 / 1790)

@esarver
Copy link
Member Author

esarver commented May 6, 2024

The artifacts from this PR were also reviewed by Verification.

@esarver esarver merged commit d091f3c into main May 6, 2024
10 checks passed
@esarver esarver deleted the bug/tsp-468-prompt-return-too-early branch May 6, 2024 12:39
@esarver esarver restored the bug/tsp-468-prompt-return-too-early branch May 6, 2024 12:40
esarver added a commit that referenced this pull request May 6, 2024
@esarver esarver deleted the bug/tsp-468-prompt-return-too-early branch May 6, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants