-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global jsonrpc ref for umd bundle and fix webpack warning #17
base: master
Are you sure you want to change the base?
Conversation
There's a bit trouble: microbundle > rollup-plugin-alias > slash "^3.0.0" that requires node >=8. |
@antongolub Could you remove microbundle ? |
Oh... build task requires microbundle to produce the all variety of packages: |
2c6ce12
to
e15cf27
Compare
Travis-ci has ability to cache directories between jobs/stages. But I cannot to make this feature work( Here's the config: language: node_js
sudo: false
install: skip
before_install: skip
before_script: skip
script: skip
cache:
directories:
- ./target
- target
- node_modules
stages:
- build
- test
jobs:
include:
- stage: build
node_js:
- "12"
install:
- yarn install
- yarn build
script: skip
- stage: test
node_js:
- "6"
- "8"
- "10"
- "12"
- "13"
install: skip
before_install: skip
before_script: skip
script:
- yarn test
Any thoughts? |
bf1ba69
to
c3063d0
Compare
"There is one cache per branch and language version" #caches-and-build-matrices |
a94df8e
to
d2b57f6
Compare
@zensh And finally it works. I just raise NodeJs version at the build stage and return it back after. So the test validates bundles against v6. install:
- 'if [ "${TRAVIS_NODE_VERSION}" = "6" ] ; then nvm use 8 ; fi ;'
- yarn install
- yarn build
- 'if [ "${TRAVIS_NODE_VERSION}" = "6" ] ; then nvm use "${TRAVIS_NODE_VERSION}" && node --version ; fi ;'
script:
- yarn test |
@zensh, any objections? |
@antongolub Hi, I don't like microbundle. |
Ok... I'll try find another solution, but not right now. |
@zensh, I've replaced |
What's the latest here? Anything stopping this PR getting merged? |
closes #15
closes #16
@zensh, could you review this PR?