Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/job edit #240

Merged
merged 12 commits into from
Dec 21, 2023
Merged

Fix/job edit #240

merged 12 commits into from
Dec 21, 2023

Conversation

otytlandsvik
Copy link
Collaborator

@otytlandsvik otytlandsvik commented Dec 20, 2023 •
edited
Loading

💎 Fix Job edit and archive view

🌠 Fixed job edit form

  • The correct dates are now displayed in the edit form
  • Added validator for optional dates to fix bug where jobs without due date could not be updated
  • ✨ Added a prefix option for the text field component to avoid inputting invalid job links
    image

✨ Added upcoming jobs and archived jobs view

  • By default, only jobs with due date in the future are shown on the jobs page
  • A toggle button has been added to toggle archive view
    📷 Archive view
    Screenshot from 2023-12-20 16-33-01
    📷 Responsive
    image
  • 🪄 The jobs page was also rewritten with Chakra-ui

🐛 Fix various bugs

  • Fix bug with chip filtering of jobs
  • Fix bug with jobs sorting
  • Change placeholder text on main page to juleferie instead of vinterferie

This was linked to issues Dec 20, 2023
Job expiry date #213
Closed
Job dates are set incorrectly in job edit form #226
Closed
Add default https:// prefix to job links #227
Closed
FredrikMorstad
FredrikMorstad approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@FredrikMorstad FredrikMorstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes 🙌 I left two comments that would be nice to look at

src/components/pages/jobs/Jobs.tsx Outdated Show resolved Hide resolved
src/components/pages/jobs/Jobs.tsx Outdated Show resolved Hide resolved
@otytlandsvik otytlandsvik merged commit 61a279e into master Dec 21, 2023
1 check passed
@otytlandsvik otytlandsvik deleted the fix/job-edit branch December 21, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikMorstad FredrikMorstad FredrikMorstad approved these changes

@hauks1 hauks1 Awaiting requested review from hauks1

@stiansolli stiansolli Awaiting requested review from stiansolli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default https:// prefix to job links Job dates are set incorrectly in job edit form Job expiry date
2 participants
@otytlandsvik @FredrikMorstad