Primitive lists #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ListMarshaller to set true for the new isList parameter to addChild, a feature required for the forthcoming JSON implementation. This was also needed (I think) to support lists of primitives, but I haven't verified this... I just didn't see how it could be done based on the ListMarshaller writeObject() code.
This reverts commit 918f4e5.
There are some peculiar differences from the XML implementation because the name of an element is not included within that element, but rather on the parent object. The main visible difference is that JsonUtil's method parameters are a bit different from XmlUtil's.
I do notice though that this doesn't test writing, and I don't actually have any use for JSON writing at the moment, so I haven't tested that yet.
Per feedback from teh conkling.
List children are formated as <list><value>42</value></list>. As with complex lists, the child element name is inconsequential, value is simply the default used when writing out a primitive list.
|
Oh, the list example is no longer in the last commit. 0a11542 is the one you want. |
tconkling
force-pushed
the
master
branch
3 times, most recently
from
1d01aaa
to
6a2dea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitive list implementation complete for JSON and XML. The XML format is shown in the last commit from this PR. This one depends on the JSON support PR, so once that one is in, there should be fewer commits showing up here. Unfortunately, the "Ignore compiled python bytecode" commit was on my master branch and I don't think I can get rid of it, so that one and its reversion are included here, which I don't think I can avoid, unless I want to exclude it from every branch I ever make for PRs.
I've since realized that the way to develop in this environment is to do all dev on a branch, issue the PR, then only put on master once the PR has been responded to, which is how I'll operate going forward.