Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group endpoints #121

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LucasGinard
Copy link

Buenas Martin y Marcelo que tal ? , mando el pull request solo la agrupacion de endpoints.

Cambios:

Antes Después
Antes Después

Aguardo feedback en caso de cambios.

Copy link
Owner

@tchx84 tchx84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but minor comments.

app/service.py Show resolved Hide resolved
app/service.py Show resolved Hide resolved
Copy link
Owner

@tchx84 tchx84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, one last comment, and check the pipeline failure.

app/models.py Outdated Show resolved Hide resolved
@LucasGinard
Copy link
Author

Corrected the pipeline, in theory it was a format issue, could it be run again to confirm?

@tchx84
Copy link
Owner

tchx84 commented Sep 18, 2024

@LucasGinard can you rebased on master?

app/service.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants