Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static code analysis warnings #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HacksBugsAndRockAndRoll

still looking for the culprit behind #83

some findings from cppcheck fixed

  • lots of initialization stuff
  • overrides
  • const for buffer parameters

actual logic changes

  • in lib/Hoymiles/src/parser/AlarmLogParser.cpp
  • all the places printing the inverter serial as hex string

@stefan123t
Copy link

@HacksBugsAndRockAndRoll how did you use cppcheck, may we add this easily to the github actions ?
Some of the findings may be useful initializations, easier syntax, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants