Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavGuard #786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NavGuard #786

wants to merge 1 commit into from

Conversation

florian-senn
Copy link

Unauthorized users only can visit MainPage and Login

Unauthorized users only can visit MainPage and Login
@tbnobody
Copy link
Owner

tbnobody commented Apr 9, 2023

But I want non-authorized users to visit the info views.
If you don't want this, just deactivate this setting:
image

On the other hand, the backend is still readable with your PR. Just the frontend prevents the route access.

@florian-senn
Copy link
Author

Unter der Route "/" ist ja die Live-Ansicht, diese ist dadurch noch zugänglich. Aber ja, es schützt nur das Frontend.

@3DJupp
Copy link

3DJupp commented Feb 26, 2024

Hey, I mean, thats always something that should be taken care of. I recommend to use Cloudflare Access or any other kind of reverse proxy for remote access, so the ESP will not host anything in the web. For accessing the ESP in a dedicated VLAN i could allow or block certain protocols and ports.

@stefan123t
Copy link

@florian-senn we introduced the AuthenticationManager with ESPAsyncWebServer in #2320.
Is this PR still needed or would you prefer to implement your changes based on the current master / trunk ?

@florian-senn
Copy link
Author

I've to take a closer look, as I haven't followed recent development further :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants