Log warning if histogram received cdata #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
approved these changes
Apr 4, 2024
| @@ -12,6 +12,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - `tnt_election_leader_idle` metric. | |||
|
|
|||
| - Histogram now logs a warning if `observe` is called with `cdata` value. | |||
DifferentialOrange
approved these changes
Apr 4, 2024
DifferentialOrange
added a commit
to DifferentialOrange/tarantool
that referenced
this pull request
Jul 10, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
DifferentialOrange
added a commit
to DifferentialOrange/tarantool
that referenced
this pull request
Jul 10, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
DifferentialOrange
added a commit
to DifferentialOrange/tarantool
that referenced
this pull request
Jul 16, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
Totktonada
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Jul 22, 2024
Bump metrics package submodule. Commits from PRs [1-4] affect Tarantool, the other ones are related to module infrastructure. 1. tarantool/metrics#482 2. tarantool/metrics#483 3. tarantool/metrics#484 4. tarantool/metrics#491 NO_DOC=doc is a part of submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cdata values as historgam observations is dangerous, as described in #480. On the other hand, plenty of clients (e.g. tdg) use cdata with this collector. We decided not to throw an error here, at least for now.
I didn't forget about
Close #480