Allow resetting and freshly populating collection/list settings via CLI flags #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septatrix
force-pushed
the
feature/cli-reset-list
branch
from
57c899d
to
3e0a7e1
Compare
behrmann
reviewed
Nov 21, 2024
Previously it was only possible to completely reset but not append, or only append but not reset to collection/list settings via command line arguments. Now we track if a setting has ever been set to None (i.e. reset) during command line parsing. This information is used during value finalization to decide whether to merge both collections or only keep the CLI value.
septatrix
force-pushed
the
feature/cli-reset-list
branch
from
3e0a7e1
to
9168921
Compare
DaanDeMeyer
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was only possible to completely reset but not append, or only append but not reset to collection/list settings via command line arguments.
Now we track if a setting has ever been set to None (i.e. reset) during command line parsing.
This information is used during value finalization to decide whether to merge both collections or only keep the CLI value.
This fixes #3208