Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonw15-b: Add variant for new Bonobo #567

Merged
merged 3 commits into from
Nov 4, 2024
Merged

bonw15-b: Add variant for new Bonobo #567

merged 3 commits into from
Nov 4, 2024

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Jul 12, 2024 •
edited
Loading

@crawfxrd crawfxrd force-pushed the bonw15-b branch 2 times, most recently from 38e5797 to 0d3842c Compare July 18, 2024 16:50
@crawfxrd crawfxrd force-pushed the bonw15-b branch 2 times, most recently from be15365 to a9ca1e0 Compare August 7, 2024 17:38
@crawfxrd crawfxrd marked this pull request as ready for review August 7, 2024 17:39
@crawfxrd crawfxrd requested review from a team August 7, 2024 17:39
@crawfxrd
bonw15-b: Add variant for new Bonobo
1480bae 
Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd
bonw15-b: Update CSME
d7a7e9a 
Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd
bonw15-b: Increase hotplug memory
245c033 
Table 4-6 states that BIOS should reserve:

- 96 MiB non-prefetchable memory
- 2x16 GiB prefetchable memory

So increase to 96 MiB and 16 GiB.

Ref: Barlow Ridge BIOS Implementation Guide (#782921)
Signed-off-by: Tim Crawford <[email protected]>
leviport
leviport approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining issues with TB controller will be addressed later. With those known, I'm approving based off the rest of prior testing that was done.

@jackpot51 jackpot51 merged commit 7265ca3 into master Nov 4, 2024
@jackpot51 jackpot51 deleted the bonw15-b branch November 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviport leviport leviport approved these changes

@jackpot51 jackpot51 jackpot51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crawfxrd @jackpot51 @leviport