peci: Add timeouts to infinitely blocking waits #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add timeouts to the legacy PECI implementation to prevent the EC locking up when PECI stops working, such as during S0ix opportunistic suspend. This is not the optimal solution, as PECI should not be available at all to cause the lock up in the first place, but it at least prevents the issue. Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
force-pushed
the
peci-timeout
branch
from
f4ae9ab
to
fcee9db
Compare
jackpot51
approved these changes
Oct 10, 2023
jacobgkau
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Both me and @leviport have had trouble recreating the issue on-demand across two lemp10's and a darp7. However, I've smoke-tested this on both models, and it doesn't seem to cause any issues. We'll perform full regression testing with the firmware release PRs (which is where this was previously observed on darp7.)
(Edit: As part of testing this, I did confirm that the fan still spins down after entering suspend if it's spun up before entering suspend.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeouts to the legacy PECI implementation to prevent the EC locking up when PECI stops working, such as during S0ix opportunistic suspend.
This is not the optimal solution, as PECI should not be available at all to cause the lock up in the first place, but it at least prevents the issue.
Test:
Resolves: #412
Ref: #389