Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notifier] Add GoIP bridge #1233

Merged
merged 2 commits into from
Aug 12, 2023
Merged

[Notifier] Add GoIP bridge #1233

merged 2 commits into from
Aug 12, 2023

Conversation

ahmedghanem00
Copy link
Contributor

Q A
License MIT
Doc issue/PR symfony/symfony#51349

Add GoIP notifier bridge

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 11, 2023 21:03
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1233/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1233/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/goip-notifier:^6.4'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@ahmedghanem00 ahmedghanem00 mentioned this pull request Aug 11, 2023
Closed
auto-merge was automatically disabled August 12, 2023 09:43

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 12, 2023 09:43
fabpot added a commit to symfony/symfony that referenced this pull request Aug 12, 2023
@fabpot
feature #51349 [Notifier] Add GoIP bridge (ahmedghanem00)
bacbe8d 
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Notifier] Add GoIP bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#18742
| Recipes       | symfony/recipes#1233

GoIP is a GSM Gateway/SIM-Hub that provides the ability to send SMS messages over the network. I think it would be useful to add an integration for it with the Symfony Notifier

Commits
-------

066d0f8 [Notifier] Add GoIP bridge
@fabpot fabpot disabled auto-merge August 12, 2023 13:09
@fabpot fabpot merged commit 26deab4 into symfony:main Aug 12, 2023
1 of 2 checks passed
@ahmedghanem00 ahmedghanem00 deleted the goip-notifier branch August 12, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Needs new Package Waiting Code Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedghanem00 @fabpot @OskarStark