-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phrase translation provider recipe #1172
Conversation
wickedOne
commented
Feb 4, 2023
•
edited
Loading
edited
Q | A |
---|---|
License | MIT |
Doc PR | symfony/symfony-docs#17861 |
PR | symfony/symfony#49231 |
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/translation3.3 vs 5.3diff --git a/symfony/translation/3.3/config/packages/translation.yaml b/symfony/translation/5.3/config/packages/translation.yaml
index 05a2b3d..abb76aa 100644
--- a/symfony/translation/3.3/config/packages/translation.yaml
+++ b/symfony/translation/5.3/config/packages/translation.yaml
@@ -4,3 +4,10 @@ framework:
default_path: '%kernel.project_dir%/translations'
fallbacks:
- en
+# providers:
+# crowdin:
+# dsn: '%env(CROWDIN_DSN)%'
+# loco:
+# dsn: '%env(LOCO_DSN)%'
+# lokalise:
+# dsn: '%env(LOKALISE_DSN)%' 5.3 vs 6.3diff --git a/symfony/translation/5.3/config/packages/translation.yaml b/symfony/translation/6.3/config/packages/translation.yaml
index abb76aa..888f0ba 100644
--- a/symfony/translation/5.3/config/packages/translation.yaml
+++ b/symfony/translation/6.3/config/packages/translation.yaml
@@ -11,3 +11,5 @@ framework:
# dsn: '%env(LOCO_DSN)%'
# lokalise:
# dsn: '%env(LOKALISE_DSN)%'
+# phrase:
+# dsn: '%env(PHRASE_DSN)%' |
maybe it's sensible to extend the examples in # providers:
# crowdin:
# dsn: '%env(CROWDIN_DSN)%'
# loco:
# dsn: '%env(LOCO_DSN)%'
# lokalise:
# dsn: '%env(LOKALISE_DSN)%'
# phrase:
# dsn: '%env(PHRASE_DSN)%' |
Head branch was pushed to by a user without write access
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Translation] Phrase translation provider | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #49142 | License | MIT | Doc PR | symfony/symfony-docs#17861 | Recipe PR | symfony/recipes#1172 Commits ------- b8f35ba [Translation] Phrase translation provider