Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phrase translation provider recipe #1172

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

wickedOne
Copy link
Contributor

@wickedOne wickedOne commented Feb 4, 2023

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 4, 2023 04:57
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1172/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1172/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/phrase-translation-provider:^6.3' 'symfony/translation:^6.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/translation

3.3 vs 5.3
diff --git a/symfony/translation/3.3/config/packages/translation.yaml b/symfony/translation/5.3/config/packages/translation.yaml
index 05a2b3d..abb76aa 100644
--- a/symfony/translation/3.3/config/packages/translation.yaml
+++ b/symfony/translation/5.3/config/packages/translation.yaml
@@ -4,3 +4,10 @@ framework:
         default_path: '%kernel.project_dir%/translations'
         fallbacks:
             - en
+#        providers:
+#            crowdin:
+#                dsn: '%env(CROWDIN_DSN)%'
+#            loco:
+#                dsn: '%env(LOCO_DSN)%'
+#            lokalise:
+#                dsn: '%env(LOKALISE_DSN)%'
5.3 vs 6.3
diff --git a/symfony/translation/5.3/config/packages/translation.yaml b/symfony/translation/6.3/config/packages/translation.yaml
index abb76aa..888f0ba 100644
--- a/symfony/translation/5.3/config/packages/translation.yaml
+++ b/symfony/translation/6.3/config/packages/translation.yaml
@@ -11,3 +11,5 @@ framework:
 #                dsn: '%env(LOCO_DSN)%'
 #            lokalise:
 #                dsn: '%env(LOKALISE_DSN)%'
+#            phrase:
+#                dsn: '%env(PHRASE_DSN)%'

@chr-hertel
Copy link
Contributor

maybe it's sensible to extend the examples in symfony/translation/5.3/config/packages/translation.yaml

#        providers:
#            crowdin:
#                dsn: '%env(CROWDIN_DSN)%'
#            loco:
#                dsn: '%env(LOCO_DSN)%'
#            lokalise:
#                dsn: '%env(LOKALISE_DSN)%'
#            phrase:
#                dsn: '%env(PHRASE_DSN)%'

auto-merge was automatically disabled February 4, 2023 10:51

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) February 4, 2023 10:51
fabpot added a commit to symfony/symfony that referenced this pull request Aug 1, 2023
This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Translation] Phrase translation provider

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #49142
| License       | MIT
| Doc PR        | symfony/symfony-docs#17861
| Recipe PR  | symfony/recipes#1172

Commits
-------

b8f35ba [Translation] Phrase translation provider
@fabpot fabpot disabled auto-merge August 12, 2023 13:09
@fabpot fabpot merged commit fecd333 into symfony:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants