Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search_json to handle empty collection #445

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Update search_json to handle empty collection #445

merged 2 commits into from
Jul 25, 2024

Conversation

sylhare
Copy link
Owner

@sylhare sylhare commented Jul 24, 2024 •
edited
Loading

Description

To fix #441 when there are no collection.

Checked that search works:

  • with collection hidden in the config
  • with no _portfolio folder
  • with collection

@sylhare sylhare added the fix label Jul 24, 2024
@sylhare sylhare marked this pull request as ready for review July 25, 2024 20:14
@sylhare sylhare merged commit dc0657c into master Jul 25, 2024
6 checks passed
@sylhare sylhare deleted the empty-collection branch July 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment portfolio on _config.yml "Search broken"
1 participant
@sylhare