Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment portfolio on _config.yml "Search broken" #441

Closed
Vctrsnts opened this issue May 22, 2024 · 2 comments · Fixed by #445
Closed

Comment portfolio on _config.yml "Search broken" #441

Vctrsnts opened this issue May 22, 2024 · 2 comments · Fixed by #445
Assignees
Labels

Comments

@Vctrsnts
Copy link

Describe the bug
I Work with docker bretfisher/jekyll-serve:latest with this versions:

  • Jekyll: 4.3.3
  • Ruby: 3.1.5
  • Fork about this theme

To Reproduce
Steps to reproduce the behavior:

  1. I fork the theme and go to the _config.yml
  2. Comment with this # the lines about portfolio:
#collections:
#  portfolio:
#    output: true
#    permalink: /:collection/:name
  1. Run the theme and use the search option on firefox
  2. With F12 I watch this message:
Uncaught Error: SimpleJekyllSearch --- failed to get JSON (/assets/data/search.liquid) 
a http://192.6.0.40:4001/assets/js/vendor/simple-jekyll-search.min.js:6
SimpleJekyllSearch http://192.6.0.40:4001/assets/js/vendor/simple-jekyll-search.min.js:6
h http://192.6.0.40:4001/assets/js/vendor/simple-jekyll-search.min.js:6
load http://192.6.0.40:4001/assets/js/vendor/simple-jekyll-search.min.js:6
SimpleJekyllSearch http://192.6.0.40:4001/assets/js/vendor/simple-jekyll-search.min.js:6
<anonymous> http://192.6.0.40:4001/search/:35
  1. If you not comment the lines of portfolio all work perfect
  2. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
github

Additional context
Add any other context about the problem here.

@sylhare
Copy link
Owner

sylhare commented May 22, 2024

Ok I see where this is from, the JSON is created by looping through the collections. With no collection the JSON might get broken or the liquid template might be failing.

@sylhare
Copy link
Owner

sylhare commented Jul 25, 2024

A fix has been merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants