Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated: Section 12, 13 and 14 in R for Rep #91

Merged
merged 6 commits into from
Aug 14, 2020

Conversation

rkkmk
Copy link
Collaborator

@rkkmk rkkmk commented Apr 10, 2020

Let me just push this for now...

@rkkmk rkkmk linked an issue Apr 10, 2020 that may be closed by this pull request
@rkkmk rkkmk changed the title 1/2 of Section 12 in R for Rep Translated: Section 12 in R for Rep Apr 11, 2020
@rkkmk rkkmk linked an issue Apr 11, 2020 that may be closed by this pull request
@TomKellyGenetics
Copy link
Member

Thanks for the update @rkkmk. Feel free to open pull requests for lessons in progress. We can review and merge once they're ready. Seems like this one is complete. Any willing reviewers? @megane0-0 @kozo2 @masamiy

@rkkmk rkkmk linked an issue Apr 19, 2020 that may be closed by this pull request
@rkkmk rkkmk changed the title Translated: Section 12 in R for Rep Translated: Section 12, 13 in R for Rep Apr 19, 2020
@rkkmk rkkmk changed the title Translated: Section 12, 13 in R for Rep Translated: Section 12, 13 and 14 in R for Rep Apr 26, 2020
@rkkmk rkkmk linked an issue Apr 26, 2020 that may be closed by this pull request
Copy link
Collaborator

@masamiy masamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I went through this, but there may be a new version of translation file as the original has changed. They now use pivot_###() instead of spread ?

po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
@TomKellyGenetics
Copy link
Member

Let’s complete translation of this version first. We can display the same version of English lessons in the web preview.

It should be possible to pull updates of the original lessons but we still need to test the code to do that. A full Japanese version of the lessons is a great milestone. Then we can figure out how to maintain and update it.

@TomKellyGenetics
Copy link
Member

Ping me when it's merged and I'll give the scripts (#81 & #82) a whirl to update the webpages. Did we decide on whether accept Masami's suggestions before merging? @masamiy @MasamiYama

@TomKellyGenetics
Copy link
Member

@kozo2 You can see the changes here in the "files" tab.

Copy link
Collaborator

@kozo2 kozo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomKellyGenetics Thank you for information.
I created some reviews.
Please let me know if there are any problems with this way.

po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
po/r-novice-gapminder.ja.po Show resolved Hide resolved
@joelnitta joelnitta mentioned this pull request Aug 14, 2020
@joelnitta joelnitta merged commit 724ccf2 into swcarpentry-ja:ja Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants